Close Pinned Plugin Feature #6320
Conversation
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
I checked functionality wise.
-
There are errors in browser console like
Invalid DOM propertyfill-rule. Did you meanfillRule?,Invalid DOM propertyclip-rule. Did you meanclipRule?and[TIMEOUT] Timeout for call pinView from sidePanel -
Icon for restore plugin is appearing like this on my screen:
- If I open files in editors, that icon starts moving on right and files start wrapping keeping this much right margin from that icon
- If I move Solidity compiler plugin on right and close it. Plugin icon panel still shows it on right.
- In such case, If I click on RemixAi assistant, it opens Solidity compiler plugin on right side
For point 1, I fixed the regression that was causing the console errors. The last point you made is also addressed by fixing this regression. The plugin will still show on the right because it is still pinned. when you click the restore icon, it restores it back as pinned. We agreed on the last team call not to close or unpin any pinned plugin that gets closed. I moved the restore icon to the topbar because the tabs bar has very precise settings that would not be fixed easily. |
There was a problem hiding this comment.
-
On Solidity Compiler left & right, In browser console, I see:
compiler-container.tsx:380 Uncaught (in promise) TypeError: Cannot read properties of null (reading 'selectorList') at compiler-container.tsx:380:49That is not a case on live -
Icon looks like this on top bar for me:
I think it should be well aligned with other UI elements on top bar
- If a plugin is hidden on right side and I click on it from left side icon panel, it doesn't appear
- I think tooltip on X icon should be
Hide pluginand while restoring it tooltip on icon can show plugin name if possible likeOpen RemixAI Assistant plugin
bedroomeyes555
left a comment
bedroomeyes555
left a comment
There was a problem hiding this comment.
No direct security risks are apparent in these changes—they are UI/UX improvements for plugin management.
No handling of user credentials, private keys, or sensitive workspace data.
Events and DOM operations are local and do not expose data externally.
Recommendation:
If Remix IDE supports third-party plugins (especially those from remote sources), always ensure: Plugin profile objects are sanitized.
Only trusted plugins can trigger or respond to internal events.
UI state changes cannot be hijacked via crafted plugin data.
fixes #6305 290825